portugalfuturista/elixir
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

BUGFIX: Don't double quote DT compatible strings (#229)

Browse source 
Both query.py and api.py call parse.quote(ident) which perform
url encoding twice on the identifier. For instance, when
ident="linux,kvm" the first encoding done in api.py changes the
ident to   GNU nano 6.2   /home/tamir/elixir/.git/COMMIT_EDITMSG *          │
BUGFIX: Don't double quote DT compatible strings

Both query.py and api.py call parse.quote(ident) which perform
url encoding twice on the identifier. For instance, when
ident="linux,kvm" the first encoding done in api.py changes the
ident to 'wow%2Cey' but the second encoding done in query.py
changes it to 'wow%252Cey' which is no longer valid.

Remove the call to parse.quote on api.py as only one quoting is
necessary, the one in query.py
This commit is contained in:
Tamir Carmeli 2022-11-23 16:20:27 +02:00 committed by GitHub
parent cb5fc9fbdc
commit 76197b5973
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
api/api.py
View file

@ -56,9 +56,6 @@ class IdentGetter:
else:
family = 'C'
if family == 'B': #DT compatible strings are quoted in the database
ident = parse.quote(ident)
symbol_definitions, symbol_references, symbol_doccomments = query('ident', version, ident, family)
resp.body = json.dumps(
{

1
query.py
View file

@ -244,6 +244,7 @@ def get_idents_comps(version, ident):
symbol_dts = []
symbol_docs = []
# DT compatible strings are quoted in the database
ident = parse.quote(ident)
if not dts_comp_support or not db.comps.exists(ident):