From 0a05e42240c4266a5e7cdd37e7fd60ddd97f443f Mon Sep 17 00:00:00 2001 From: Khairul Azhar Kasmiran Date: Sun, 12 May 2024 15:25:46 +0800 Subject: [PATCH] Add note regarding rz_bin_reloc_free and bin_coff (#4488) --- librz/bin/bin.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/librz/bin/bin.c b/librz/bin/bin.c index fcd4495757..4db820647d 100644 --- a/librz/bin/bin.c +++ b/librz/bin/bin.c @@ -207,6 +207,9 @@ RZ_API void rz_bin_reloc_free(RZ_NULLABLE RzBinReloc *reloc) { * TODO: leak in bin_elf, but it will cause double free in bin_pe if free here, * Because in the bin_elf implementation RzBinObject->imports and RzBinObject->relocs->imports * are two pieces of data, but they are linked to each other in bin_pe + * TODO: also, double free in bin_coff if free here, + * Because in the bin_coff implementation imports and symbols are shared + * between relocs */ // rz_bin_import_free(reloc->import); // rz_bin_symbol_free(reloc->symbol);