portugalfuturista/rizin
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't show ; -1 comment if ahi is used (#6451)

Browse source
This commit is contained in:
Khairul Azhar Kasmiran 2026-06-01 11:38:11 +08:00 committed by GitHub
parent 6d7c38cf5b
commit 0dfb7b9189
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
librz/core/disasm.c
View file

@ -4224,7 +4224,7 @@ static void ds_print_ptr(RzDisasmState *ds, int len, int idx) {
ds->printed_flag_addr = refaddr;
}
} else {
if (refaddr == UT64_MAX || refaddr == UT32_MAX) {
if ((refaddr == UT64_MAX || refaddr == UT32_MAX) && (!ds->hint || !ds->hint->immbase)) {
ds_begin_comment(ds);
ds_comment(ds, true, "; -1");
} else if (((char)refaddr > 0) && refaddr >= '!' && refaddr <= '~') {

8
test/db/cmd/cmd_ahi
View file

@ -345,8 +345,8 @@ pd 1
EOF
EXPECT=<<EOF
0x00000000 cmp eax, 0xffffffff ; -1
0x00000000 cmp eax, -1 ; -1
0x00000000 cmp eax, 4294967295 ; -1
0x00000000 cmp eax, -1
0x00000000 cmp eax, 4294967295
EOF
RUN
@ -372,8 +372,8 @@ pd 1
EOF
EXPECT=<<EOF
0x00000000 cmp eax, 0xffffffff ; -1
0x00000000 cmp eax, -1 ; -1
0x00000000 cmp eax, 4294967295 ; -1
0x00000000 cmp eax, -1
0x00000000 cmp eax, 4294967295
0x00000000 cmp rax, 0xffffffffffffffff
0x00000000 cmp rax, -1