portugalfuturista/rizin
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Bit-Vector: fail when cast growth cant resize storage (#6219)

Browse source
This commit is contained in:
Alok Kumar Mishra 2026-04-13 14:20:39 +05:30 committed by GitHub
parent 0bd98c9628
commit 1c22e9d6a0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
librz/util/bitvector.c
View file

@ -32,16 +32,29 @@ ut8 reverse_lt_8bits(ut8 x, ut8 w) {
/**
* \brief Resize or allocate bv->large_a to \p new_size bytes.
*/
static void resize_large_a(RzBitVector *bv, size_t n_bytes) {
static bool resize_large_a(RzBitVector *bv, size_t n_bytes) {
if (bv->stack_alloc) {
bv->bits.large_a = RZ_NEWS0(ut8, n_bytes);
ut8 *tmp = RZ_NEWS0(ut8, n_bytes);
// dont drop stack backed contents unless heap alloc succeeded.
if (!tmp) {
return false;
}
bv->bits.large_a = tmp;
bv->stack_alloc = false;
} else if (!bv->bits.large_a) {
bv->bits.large_a = RZ_NEWS0(ut8, n_bytes);
if (!bv->bits.large_a) {
return false;
}
} else {
bv->bits.large_a = realloc(bv->bits.large_a, n_bytes);
ut8 *tmp = realloc(bv->bits.large_a, n_bytes);
if (!tmp) {
return false;
}
bv->bits.large_a = tmp;
}
bv->_elem_len = n_bytes;
return true;
}
/**
@ -2269,7 +2282,11 @@ RZ_API bool rz_bv_cast_inplace(RZ_INOUT RZ_NONNULL RzBitVector *bv, ut32 to_size
}
if (NELEM(to_size, BV_ELEM_SIZE) > bv->_elem_len) {
// The bit vector needs a larger buffer.
resize_large_a(bv, NELEM(to_size, BV_ELEM_SIZE));
// warn and abort the cast if the backing storage cant be extended.
if (!resize_large_a(bv, NELEM(to_size, BV_ELEM_SIZE))) {
rz_warn_if_reached();
return false;
}
}
size_t old_size = bv->len;
if (bv->len <= 64) {