portugalfuturista/rizin
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

?**: Use rz_str_split_list_regex() instead (#5542)

Browse source
This commit is contained in:
Khairul Azhar Kasmiran 2025-11-21 23:13:08 +08:00 committed by GitHub
parent 098ff8fda6
commit 1fdb34c746
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 58 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

62
librz/core/cmd/cmd_help.c
View file

@ -135,74 +135,20 @@ static char *cons_hud_help_string(const char *s) {
RZ_LOG_ERROR("Hud mode requires scr.interactive=true.\n");
return NULL;
}
char *str_start, *track, *ret, *buf = rz_str_dup(s);
char *buf = rz_str_dup(s);
if (!buf) {
return NULL;
}
RzList *fl = rz_list_newf(free);
int i;
if (!fl) {
free(buf);
return NULL;
}
/* Reconstruct a help string list from the given string amalgamation `s`, assuming that
* 1. Every command has a help string starting with '#'.
* 2. The '#' is always on the first line.
* It's probably better not to amalgamate the help strings in the first place, but this is a start.
*/
bool line_has_hash = false;
char *prev_null = NULL;
char *prev_str_start = NULL;
for (str_start = buf, i = 0; buf[i]; i++) {
if (buf[i] == '#') {
line_has_hash = true;
}
if (buf[i] != '\n') {
continue;
}
buf[i] = 0;
if (line_has_hash) {
line_has_hash = false;
prev_null = &buf[i];
if (*str_start) {
track = rz_str_dup(str_start);
if (!rz_list_append(fl, track)) {
free(track);
break;
}
}
prev_str_start = str_start;
} else {
if (!prev_null) {
RZ_LOG_ERROR("prev_null is NULL");
free(buf);
rz_list_free(fl);
return NULL;
}
*prev_null = '\n';
prev_null = &buf[i];
if (!prev_str_start) {
RZ_LOG_ERROR("prev_str_start is NULL");
free(buf);
rz_list_free(fl);
return NULL;
}
str_start = prev_str_start;
if (*str_start) {
free(rz_list_pop(fl));
track = rz_str_dup(str_start);
if (!rz_list_append(fl, track)) {
free(track);
break;
}
}
}
str_start = buf + i + 1;
}
ret = rz_cons_hud(fl, NULL);
RzList *help_strings = rz_str_split_list_regex(buf, "\\n(?=[^\\n]+\\#)", 0);
char *ret = rz_cons_hud(help_strings, NULL);
free(buf);
rz_list_free(fl);
rz_list_free(help_strings);
return ret;
}