portugalfuturista/rizin
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cast immediate values to unsigned char instead of char (#7871)

Browse source 
for compilers that default to signed char, wrong values were generated by this cast

example:
$ # before
$ rasm2 -a sh -d 'ffc8'
tst 0xFFFFFFFF,r0

$ # after
$ rasm2 -a sh -d 'ffc8'
tst 0xFF,r0
This commit is contained in:
Nils Berg 2017-07-07 00:31:37 +02:00 committed by radare
parent 86949245cd
commit df82290e43
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libr/asm/arch/sh/gnu/sh-dis.c
View file

@ -90,7 +90,7 @@ print_insn_shx (bfd_vma memaddr, struct disassemble_info *info)
imm = (nibs[2] << 4) | (nibs[3]);
if (imm & 0x80)
imm |= ~0xff;
imm = ((char)imm) * 2 + 4 ;
imm = ((unsigned char)imm) * 2 + 4 ;
goto ok;
case BRANCH_12:
imm = ((nibs[1]) << 8) | (nibs[2] << 4) | (nibs[3]);
@ -158,7 +158,7 @@ print_insn_shx (bfd_vma memaddr, struct disassemble_info *info)
switch (op->arg[n])
{
case A_IMM:
fprintf_fn (stream, "0x%02X", (char)(imm));
fprintf_fn (stream, "0x%02X", (unsigned char)(imm));
break;
case A_R0:
fprintf_fn (stream, "r0");