portugalfuturista/rizin
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix pre-existing memory leaks in ObjC class and winkd module handling (#6471)

Browse source 
bin/dyldcache: dyldcache_classes() built the classes vector with
rz_pvector_new(free) and the per-class methods/fields lists with
rz_list_new() (no element destructor). Each RzBinClass was therefore
plain free()'d without releasing its name, methods and fields, leaking
memory.

debug/dmp (winkd): rz_debug_dmp_init() obtained the module list from
winkd_list_modules() in the non-triage branch, scanned it for
ntoskrnl.exe and then never freed it, leaking the list and all of its
WindModule entries.

Co-authored-by: Anton Kochkov <anton.kochkov@gmail.com>
This commit is contained in:
NOT XVilka 2026-06-09 12:24:12 +08:00 committed by GitHub
parent 940292aaae
commit fb9b15eac6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
librz/bin/p/bin_dyldcache.c
View file

@ -378,7 +378,7 @@ static RzPVector /*<RzBinClass *>*/ *dyldcache_classes(RzBinFile *bf) {
return NULL;
}
RzPVector *ret = rz_pvector_new(free);
RzPVector *ret = rz_pvector_new((RzPVectorFree)rz_bin_class_free);
if (!ret) {
return NULL;
}
@ -451,8 +451,8 @@ static RzPVector /*<RzBinClass *>*/ *dyldcache_classes(RzBinFile *bf) {
RzBinClass *klass;
if (!(klass = RZ_NEW0(RzBinClass)) ||
!(klass->methods = rz_list_new()) ||
!(klass->fields = rz_list_new())) {
!(klass->methods = rz_list_newf((RzListFree)rz_bin_symbol_free)) ||
!(klass->fields = rz_list_newf((RzListFree)rz_bin_class_field_free))) {
RZ_FREE(klass);
RZ_FREE(pointers);
RZ_FREE(sections);

4
librz/debug/p/debug_dmp.c
View file

@ -116,6 +116,7 @@ static bool rz_debug_dmp_init(RzDebug *dbg, void **user) {
// Find ntoskrnl.exe module
RzListIter *it;
WindModule mod = { 0 };
RzList *modules = NULL;
if (ctx->type == DMP_DUMPTYPE_TRIAGE) {
struct rz_bin_dmp64_obj_t *obj = core->bin->cur->o->bin_obj;
dmp_driver_desc *driver;
@ -131,7 +132,7 @@ static bool rz_debug_dmp_init(RzDebug *dbg, void **user) {
} else {
WindProc kernel = { .dir_base_table = ctx->kernelDirectoryTable, .uniqueid = 4 };
ctx->windctx.target = kernel;
RzList *modules = winkd_list_modules(&ctx->windctx);
modules = winkd_list_modules(&ctx->windctx);
WindModule *m;
rz_list_foreach (modules, it, m) {
if (rz_str_endswith(m->name, "\\ntoskrnl.exe")) {
@ -164,6 +165,7 @@ static bool rz_debug_dmp_init(RzDebug *dbg, void **user) {
RZ_LOG_WARN("Failed to download ntoskrnl.pdb, many things won't work.\n");
}
}
rz_list_free(modules);
if (!ctx->windctx.profile) {
RZ_LOG_ERROR("Could not find a profile for this Windows: %s %" PFMT32d "-bit %" PFMT32u " SP %" PFMT32u "\n",