* fix(server): remove initialized notification gate to support Streamable HTTP The server's init handshake loop fatally rejected any request arriving before the `notifications/initialized` message. This breaks Streamable HTTP clients where each JSON-RPC message is a separate POST with no ordering guarantee — `tools/list` can easily arrive before `initialized`. Remove the ~40-line wait loop and enter `serve_inner` immediately after sending `InitializeResult`. The `initialized` notification is now handled as a regular notification by the main service loop, matching the TypeScript SDK behavior (validated in typescript-sdk#578). Also remove the now-unreachable `ExpectedInitializedNotification` error variant from `ServerInitializeError`. Closes #783 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(server): keep ExpectedInitializedNotification as deprecated Retain the variant for semver compatibility — removing it would be a breaking change caught by cargo-semver-checks. Mark it deprecated with a note that it is never constructed and will be removed in a future major release. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Anar Azadaliyev <anar.azadaliye@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
256 lines
9.4 KiB
Rust
256 lines
9.4 KiB
Rust
// cargo test --features "client" --package rmcp -- server_init
|
|
#![cfg(all(feature = "client", not(feature = "local")))]
|
|
mod common;
|
|
|
|
use common::handlers::TestServer;
|
|
use rmcp::{
|
|
ServiceExt,
|
|
model::{ClientJsonRpcMessage, ServerJsonRpcMessage, ServerResult},
|
|
transport::{IntoTransport, Transport},
|
|
};
|
|
|
|
fn msg(raw: &str) -> ClientJsonRpcMessage {
|
|
serde_json::from_str(raw).expect("invalid test message JSON")
|
|
}
|
|
|
|
fn init_request() -> ClientJsonRpcMessage {
|
|
msg(r#"{
|
|
"jsonrpc": "2.0",
|
|
"id": 1,
|
|
"method": "initialize",
|
|
"params": {
|
|
"protocolVersion": "2025-11-25",
|
|
"capabilities": {},
|
|
"clientInfo": { "name": "test-client", "version": "0.0.1" }
|
|
}
|
|
}"#)
|
|
}
|
|
|
|
fn initialized_notification() -> ClientJsonRpcMessage {
|
|
msg(r#"{ "jsonrpc": "2.0", "method": "notifications/initialized" }"#)
|
|
}
|
|
|
|
fn set_level_request(id: u64) -> ClientJsonRpcMessage {
|
|
msg(&format!(
|
|
r#"{{ "jsonrpc": "2.0", "id": {id}, "method": "logging/setLevel", "params": {{ "level": "info" }} }}"#
|
|
))
|
|
}
|
|
|
|
fn ping_request(id: u64) -> ClientJsonRpcMessage {
|
|
msg(&format!(
|
|
r#"{{ "jsonrpc": "2.0", "id": {id}, "method": "ping" }}"#
|
|
))
|
|
}
|
|
|
|
fn list_tools_request(id: u64) -> ClientJsonRpcMessage {
|
|
msg(&format!(
|
|
r#"{{ "jsonrpc": "2.0", "id": {id}, "method": "tools/list" }}"#
|
|
))
|
|
}
|
|
|
|
async fn do_initialize(client: &mut impl Transport<rmcp::RoleClient>) {
|
|
client.send(init_request()).await.unwrap();
|
|
let _response = client.receive().await.unwrap();
|
|
}
|
|
|
|
// Server handles setLevel sent before initialized notification (processed by serve_inner).
|
|
#[tokio::test]
|
|
async fn server_init_set_level_response_is_empty_result() {
|
|
let (server_transport, client_transport) = tokio::io::duplex(4096);
|
|
let _server = tokio::spawn(async move { TestServer::new().serve(server_transport).await });
|
|
let mut client = IntoTransport::<rmcp::RoleClient, _, _>::into_transport(client_transport);
|
|
|
|
do_initialize(&mut client).await;
|
|
client.send(set_level_request(2)).await.unwrap();
|
|
|
|
// The handler may send logging notifications before the response;
|
|
// skip notifications to find the EmptyResult response.
|
|
let response = loop {
|
|
let msg = client.receive().await.unwrap();
|
|
if matches!(msg, ServerJsonRpcMessage::Response(_)) {
|
|
break msg;
|
|
}
|
|
};
|
|
assert!(
|
|
matches!(
|
|
response,
|
|
ServerJsonRpcMessage::Response(ref r)
|
|
if matches!(r.result, ServerResult::EmptyResult(_))
|
|
),
|
|
"expected EmptyResult for setLevel, got: {response:?}"
|
|
);
|
|
}
|
|
|
|
// Server initializes successfully when setLevel is sent before the initialized notification.
|
|
#[tokio::test]
|
|
async fn server_init_succeeds_after_set_level_before_initialized() {
|
|
let (server_transport, client_transport) = tokio::io::duplex(4096);
|
|
let server_handle =
|
|
tokio::spawn(async move { TestServer::new().serve(server_transport).await });
|
|
let mut client = IntoTransport::<rmcp::RoleClient, _, _>::into_transport(client_transport);
|
|
|
|
do_initialize(&mut client).await;
|
|
client.send(set_level_request(2)).await.unwrap();
|
|
// Skip notifications until we get the response
|
|
loop {
|
|
let msg = client.receive().await.unwrap();
|
|
if matches!(msg, ServerJsonRpcMessage::Response(_)) {
|
|
break;
|
|
}
|
|
}
|
|
client.send(initialized_notification()).await.unwrap();
|
|
|
|
let result = server_handle.await.unwrap();
|
|
assert!(
|
|
result.is_ok(),
|
|
"server should initialize successfully after setLevel"
|
|
);
|
|
result.unwrap().cancel().await.unwrap();
|
|
}
|
|
|
|
// Server responds with EmptyResult to ping received before initialize request.
|
|
#[tokio::test]
|
|
async fn server_init_ping_response_is_empty_result_before_initialize() {
|
|
let (server_transport, client_transport) = tokio::io::duplex(4096);
|
|
let _server = tokio::spawn(async move { TestServer::new().serve(server_transport).await });
|
|
let mut client = IntoTransport::<rmcp::RoleClient, _, _>::into_transport(client_transport);
|
|
|
|
client.send(ping_request(1)).await.unwrap();
|
|
|
|
let response = client.receive().await.unwrap();
|
|
assert!(
|
|
matches!(
|
|
response,
|
|
ServerJsonRpcMessage::Response(ref r)
|
|
if matches!(r.result, ServerResult::EmptyResult(_))
|
|
),
|
|
"expected EmptyResult for pre-initialize ping, got: {response:?}"
|
|
);
|
|
}
|
|
|
|
// Server initializes successfully when ping is sent before the initialize request.
|
|
#[tokio::test]
|
|
async fn server_init_succeeds_after_ping_before_initialize() {
|
|
let (server_transport, client_transport) = tokio::io::duplex(4096);
|
|
let server_handle =
|
|
tokio::spawn(async move { TestServer::new().serve(server_transport).await });
|
|
let mut client = IntoTransport::<rmcp::RoleClient, _, _>::into_transport(client_transport);
|
|
|
|
client.send(ping_request(1)).await.unwrap();
|
|
let _pong = client.receive().await.unwrap();
|
|
do_initialize(&mut client).await;
|
|
client.send(initialized_notification()).await.unwrap();
|
|
|
|
let result = server_handle.await.unwrap();
|
|
assert!(
|
|
result.is_ok(),
|
|
"server should initialize successfully after pre-initialize ping"
|
|
);
|
|
result.unwrap().cancel().await.unwrap();
|
|
}
|
|
|
|
// Server responds with EmptyResult to ping received before initialized.
|
|
#[tokio::test]
|
|
async fn server_init_ping_response_is_empty_result() {
|
|
let (server_transport, client_transport) = tokio::io::duplex(4096);
|
|
let _server = tokio::spawn(async move { TestServer::new().serve(server_transport).await });
|
|
let mut client = IntoTransport::<rmcp::RoleClient, _, _>::into_transport(client_transport);
|
|
|
|
do_initialize(&mut client).await;
|
|
client.send(ping_request(2)).await.unwrap();
|
|
|
|
let response = client.receive().await.unwrap();
|
|
assert!(
|
|
matches!(
|
|
response,
|
|
ServerJsonRpcMessage::Response(ref r)
|
|
if matches!(r.result, ServerResult::EmptyResult(_))
|
|
),
|
|
"expected EmptyResult for ping, got: {response:?}"
|
|
);
|
|
}
|
|
|
|
// Server initializes successfully when ping is sent before the initialized notification.
|
|
#[tokio::test]
|
|
async fn server_init_succeeds_after_ping_before_initialized() {
|
|
let (server_transport, client_transport) = tokio::io::duplex(4096);
|
|
let server_handle =
|
|
tokio::spawn(async move { TestServer::new().serve(server_transport).await });
|
|
let mut client = IntoTransport::<rmcp::RoleClient, _, _>::into_transport(client_transport);
|
|
|
|
do_initialize(&mut client).await;
|
|
client.send(ping_request(2)).await.unwrap();
|
|
let _response = client.receive().await.unwrap();
|
|
client.send(initialized_notification()).await.unwrap();
|
|
|
|
let result = server_handle.await.unwrap();
|
|
assert!(
|
|
result.is_ok(),
|
|
"server should initialize successfully after ping"
|
|
);
|
|
result.unwrap().cancel().await.unwrap();
|
|
}
|
|
|
|
// Server buffers tools/list sent before initialized and processes it after initialization.
|
|
#[tokio::test]
|
|
async fn server_init_buffers_request_before_initialized() {
|
|
let (server_transport, client_transport) = tokio::io::duplex(4096);
|
|
let server_handle =
|
|
tokio::spawn(async move { TestServer::new().serve(server_transport).await });
|
|
let mut client = IntoTransport::<rmcp::RoleClient, _, _>::into_transport(client_transport);
|
|
|
|
do_initialize(&mut client).await;
|
|
// Send tools/list before initialized notification
|
|
client.send(list_tools_request(2)).await.unwrap();
|
|
// Now send initialized notification
|
|
client.send(initialized_notification()).await.unwrap();
|
|
|
|
// The buffered tools/list should be processed — expect a response
|
|
let response = client.receive().await.unwrap();
|
|
assert!(
|
|
matches!(response, ServerJsonRpcMessage::Response(_)),
|
|
"expected response for buffered tools/list, got: {response:?}"
|
|
);
|
|
|
|
let result = server_handle.await.unwrap();
|
|
assert!(
|
|
result.is_ok(),
|
|
"server should initialize successfully when buffering pre-init messages"
|
|
);
|
|
result.unwrap().cancel().await.unwrap();
|
|
}
|
|
|
|
// Server buffers multiple requests before initialized and processes them in order.
|
|
#[tokio::test]
|
|
async fn server_init_buffers_multiple_requests_before_initialized() {
|
|
let (server_transport, client_transport) = tokio::io::duplex(4096);
|
|
let server_handle =
|
|
tokio::spawn(async move { TestServer::new().serve(server_transport).await });
|
|
let mut client = IntoTransport::<rmcp::RoleClient, _, _>::into_transport(client_transport);
|
|
|
|
do_initialize(&mut client).await;
|
|
// Send two requests before initialized
|
|
client.send(list_tools_request(2)).await.unwrap();
|
|
client.send(ping_request(3)).await.unwrap();
|
|
// Now send initialized notification
|
|
client.send(initialized_notification()).await.unwrap();
|
|
|
|
// Both buffered messages should get responses
|
|
let response1 = client.receive().await.unwrap();
|
|
let response2 = client.receive().await.unwrap();
|
|
assert!(
|
|
matches!(response1, ServerJsonRpcMessage::Response(_)),
|
|
"expected response for first buffered message, got: {response1:?}"
|
|
);
|
|
assert!(
|
|
matches!(response2, ServerJsonRpcMessage::Response(_)),
|
|
"expected response for second buffered message, got: {response2:?}"
|
|
);
|
|
|
|
let result = server_handle.await.unwrap();
|
|
assert!(
|
|
result.is_ok(),
|
|
"server should initialize successfully with multiple buffered messages"
|
|
);
|
|
result.unwrap().cancel().await.unwrap();
|
|
}
|