portugalfuturista/seL4
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

VGICMaintenance: Update spurious check

Browse source 
Ignore any VGIC maintenance interrupts that arrive if a VCPU isn't
currently running.
This commit is contained in:
Kent McLeod 2019-10-15 19:02:02 +11:00 committed by Kent Mcleod
parent 0e05f416ae
commit 2ceeb1df6f
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/arch/arm/object/vcpu.c
View file

@ -140,12 +140,14 @@ void VGICMaintenance(void)
uint32_t eisr0, eisr1;
uint32_t flags;
/* The current thread must be runnable at this point as we can only get
* a VGIC maintenance whilst we are actively running a thread with an
* associated VCPU. For the moment for the proof we leave a redundant
* check in here that this is indeed not happening */
if (!isRunnable(NODE_STATE(ksCurThread))) {
printf("Received VGIC maintenance on non-runnable thread!\n");
/* We shouldn't get a VGICMaintenance interrupt while a VCPU isn't active,
* but if one becomes pending before the VGIC is disabled we might get one
* when returning to userlevel after disabling the current VCPU. In this
* case we simply return and rely on the interrupt being raised again when
* the VCPU is reenabled.
*/
if (!ARCH_NODE_STATE(armHSVCPUActive)) {
printf("Received VGIC maintenance without active VCPU!\n");
return;
}