portugalfuturista/seL4
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

vtx: fix EPT cache attribute setting

Browse source 
Credits for this one should go to clang-11, which correctly flags that
the big `||` always yielded true and was not doing what was intended.

This means, previously the only possible cache attribute for EPT was
EPTWriteBack.

Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
This commit is contained in:
Gerwin Klein 2021-09-01 14:24:51 +10:00 committed by Gerwin Klein
parent aec0f5a3f0
commit 2d0410b1ee
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/arch/x86/kernel/ept.c
View file

@ -182,9 +182,9 @@ static ept_cache_options_t eptCacheFromVmAttr(vm_attributes_t vmAttr)
/* PAT cache options are 1-1 with ept_cache_options. But need to
verify user has specified a sensible option */
ept_cache_options_t option = vmAttr.words[0];
if (option != EPTUncacheable ||
option != EPTWriteCombining ||
option != EPTWriteThrough ||
if (option != EPTUncacheable &&
option != EPTWriteCombining &&
option != EPTWriteThrough &&
option != EPTWriteBack) {
/* No failure mode is supported here, vmAttr settings should be verified earlier */
option = EPTWriteBack;