Add note regarding rz_bin_reloc_free and bin_coff (#4488)

This commit is contained in:
Khairul Azhar Kasmiran 2024-05-12 15:25:46 +08:00 committed by GitHub
parent 524119c017
commit 0a05e42240
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -207,6 +207,9 @@ RZ_API void rz_bin_reloc_free(RZ_NULLABLE RzBinReloc *reloc) {
* TODO: leak in bin_elf, but it will cause double free in bin_pe if free here,
* Because in the bin_elf implementation RzBinObject->imports and RzBinObject->relocs->imports
* are two pieces of data, but they are linked to each other in bin_pe
* TODO: also, double free in bin_coff if free here,
* Because in the bin_coff implementation imports and symbols are shared
* between relocs
*/
// rz_bin_import_free(reloc->import);
// rz_bin_symbol_free(reloc->symbol);